fix: ensure styles are loaded in dev mode for routes containing special characters#9894
Merged
Rich-Harris merged 5 commits intosveltejs:masterfrom May 17, 2023
whataboutpereira:decode-pathname-fix
Merged
fix: ensure styles are loaded in dev mode for routes containing special characters#9894Rich-Harris merged 5 commits intosveltejs:masterfrom whataboutpereira:decode-pathname-fix
Rich-Harris merged 5 commits intosveltejs:masterfrom
whataboutpereira:decode-pathname-fix
Conversation
🦋 Changeset detectedLatest commit: cea820e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
SvelteKit doesn't decode special characters in pathnames when loading CSS modules in dev mode, resulting in an error: Internal server error: Failed to load url /src/routes/(special)/hinnap%C3%A4ring/+page.svelte?svelte=&type=style&lang.css=&inline= (resolved id: /src/routes/(special)/hinnap%C3%A4ring/+page.svelte?svelte&type=style&lang.css). Does the file exist? Actual path: /src/routes/(special)/hinnapäring/ Fix by using decodeURI on the url.pathname when loading CSS modules.
benmccann
reviewed
May 11, 2023
benmccann
changed the title
Member
|
Thank you. This would benefit from a test, are you able to add one? |
Contributor
Author
I did think about that, but unfortunately I wouldn't know where to begin. |
Rich-Harris
approved these changes
May 17, 2023
Member
|
I added a test in cea820e |
Merged
Contributor
Author
Wonderful, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SvelteKit doesn't decode special characters in pathnames when loading CSS modules in dev mode, resulting in an error:
Actual path:
/src/routes/(special)/hinnapäring/Fix by using decodeURI on the url.pathname when loading CSS modules.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.